tests: add ms cluster case #8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8752 +/- ##
==========================================
+ Coverage 75.61% 75.63% +0.02%
==========================================
Files 460 461 +1
Lines 72135 72273 +138
==========================================
+ Hits 54543 54664 +121
- Misses 14104 14116 +12
- Partials 3488 3493 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/retest |
lhy1024
approved these changes
Nov 1, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
okJiang
reviewed
Nov 1, 2024
| @@ -165,3 +182,58 @@ func waitTiupReady(t *testing.T, tag string) { | |||
| } | |||
| require.Failf(t, "TiUP is not ready", "tag: %s", tag) | |||
| } | |||
|
|
|||
| type msClusterSuite struct { | |||
There was a problem hiding this comment.
seems we can add a field ms bool to clusterSuite rather than create a new structure.
Signed-off-by: Ryan Leung <rleungx@gmail.com>
okJiang
approved these changes
Nov 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #8683
What is changed and how does it work?
Check List
Tests
Release note