Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix lints #142

Merged
merged 7 commits into from
Jan 1, 2019
Merged

Fix lints #142

merged 7 commits into from
Jan 1, 2019

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Nov 10, 2018 •
edited
Loading

@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Nov 10, 2018
@Hoverbear Hoverbear added this to the 0.5.0 milestone Nov 10, 2018
@Hoverbear Hoverbear self-assigned this Nov 10, 2018
siddontang
siddontang previously approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear requested a review from hicqu November 12, 2018 15:21
overvenus
overvenus reviewed Nov 16, 2018
View reviewed changes
overvenus
overvenus previously approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear Hoverbear requested a review from siddontang November 29, 2018 18:41
BusyJay
BusyJay reviewed Dec 26, 2018
View reviewed changes
src/raft_log.rs Outdated
@@ -1312,7 +1312,7 @@ mod test {

for (i, &(last_index, ref compact, ref wleft, wallow)) in tests.iter().enumerate() {
let store = MemStorage::new();
for i in 1u64..(last_index + 1) {
for i in 1u64..=(last_index) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

() is redundant.

BusyJay
BusyJay previously approved these changes Dec 26, 2018
View reviewed changes
@Hoverbear Hoverbear dismissed stale reviews from BusyJay and overvenus via d0ac433 December 28, 2018 20:31
@Hoverbear
Copy link
Contributor Author

The cargo fmt version changed due to staleness so I had to make a new commit. :( PTAL again.

@Hoverbear Hoverbear mentioned this pull request Dec 31, 2018
Closed
@Hoverbear
Copy link
Contributor Author

Ping

@Hoverbear Hoverbear merged commit c6b5d57 into master Jan 1, 2019
@overvenus overvenus deleted the fix-lints branch October 15, 2023 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@siddontang siddontang siddontang approved these changes

@overvenus overvenus overvenus approved these changes

@BusyJay BusyJay BusyJay left review comments

@hicqu hicqu Awaiting requested review from hicqu

Assignees

@Hoverbear Hoverbear

Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Hoverbear @siddontang @BusyJay @overvenus