Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

remove unnecessary clippy allow new_ret_no_self #174

Merged
merged 1 commit into from
Jan 30, 2019
Merged

remove unnecessary clippy allow new_ret_no_self #174

merged 1 commit into from
Jan 30, 2019

Conversation

JoshMcguigan
Copy link
Contributor

As of rust-lang/rust-clippy#3253 clippy allows returning Result when creating a new function for T, so these explicit allows are not needed.

@ngaut
Copy link
Member

ngaut commented Jan 30, 2019

LGTM

siddontang
siddontang approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@siddontang siddontang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

PTAL @BusyJay @hicqu

@BusyJay BusyJay merged commit 3eb4235 into tikv:master Jan 30, 2019
@Hoverbear Hoverbear added this to the 0.5.0 milestone Feb 11, 2019
@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Feb 11, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@siddontang siddontang siddontang approved these changes

@BusyJay BusyJay BusyJay approved these changes

Assignees
No one assigned
Labels
Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshMcguigan @ngaut @siddontang @BusyJay @Hoverbear