support to adjust max inflight msgs #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzhan211
reviewed
Jul 30, 2021
BusyJay
reviewed
Jul 30, 2021
hicqu
force-pushed
the
support-adjust-inflight-msgs
branch
4 times, most recently
from
f311a74 to
0fa1d13
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
support-adjust-inflight-msgs
branch
from
741695c to
d9ffd50
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
reviewed
Aug 2, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
reviewed
Aug 2, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
previously approved these changes
Aug 2, 2021
|
@jayzhan211 could you take a look again? |
NingLin-P
reviewed
Aug 4, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
support-adjust-inflight-msgs
branch
from
6a1c10e to
339abf3
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
force-pushed
the
support-adjust-inflight-msgs
branch
from
339abf3 to
91a8237
Compare
NingLin-P
previously approved these changes
Aug 4, 2021
Signed-off-by: qupeng <qupeng@pingcap.com>
BusyJay
approved these changes
Aug 4, 2021
NingLin-P
approved these changes
Aug 4, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qupeng qupeng@pingcap.com
Sometimes we want to custom
max-inflight-msgsfor a given peer. For example, the target peer's memory or disk usage is almost full. This PR allows this.BTW a bug in
inflight_buffers_sizeis fixed. With the patch its return value is real size instead of length.