raft: become_pre_candidate resets votes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Please also port the tests from etcd-io/etcd#8346 |
|
ping @Hoverbear |
Hoverbear
force-pushed
the
reset-pre-candidate
branch
from
2193ca3 to
0a8d736
Compare
|
@BusyJay PTAL. :) |
siddontang
reviewed
Jul 3, 2018
tests/cases/test_raft.rs
Outdated
| ); | ||
|
|
||
| // check state | ||
| assert_eq!( |
There was a problem hiding this comment.
why Candidate here? not PreCandidate?
There was a problem hiding this comment.
BusyJay
reviewed
Jul 3, 2018
tests/cases/test_raft.rs
Outdated
| // election in next round. | ||
| #[test] | ||
| fn test_prevote_with_split_vote() { | ||
| let bootstrap = |id| { |
There was a problem hiding this comment.
Why not use new_test_raft_with_prevote?
BusyJay
reviewed
Jul 3, 2018
tests/cases/test_raft.rs
Outdated
| // check whether the term values are expected | ||
| assert_eq!( | ||
| network.peers[&2].term, 3, | ||
| "peer 2 term: {:?}, want {:?}", |
There was a problem hiding this comment.
The default error message is quite informative.
There was a problem hiding this comment.
I agree. I will change it here, just changed it in #84.
BusyJay
approved these changes
Jul 4, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't reset the votes in
become_pre_candidatewhen etcd does.This PR resolves this.