Add shield text length fields #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvkelso
reviewed
Nov 10, 2021
| 'shield_text': '123456', | ||
| 'shield_text_length': '6', | ||
| 'bicycle_shield_text': '1234567', | ||
| 'bus_shield_text': '', |
There was a problem hiding this comment.
Why is 'bus_shield_text' an empty string here?
There was a problem hiding this comment.
because we're testing the case where we don't show a length when the shield text is empty. That was one of the requirements we discussed yesterday - if len < 0 or len > 6 we don't include the length field
nvkelso
approved these changes
Nov 10, 2021
nvkelso
reviewed
Nov 10, 2021
docs/layers.md
Outdated
| @@ -1498,6 +1502,7 @@ To improve performance, some road segments are merged at low and mid-zooms. To f | |||
| * `hgv_restriction`: optional property indicating limitations to heavy goods vehicle truck access. See below for list of values. Available on both point and line geometries. See also `hgv_restriction_shield_text`. | |||
| * `hgv_time_restrictions` - optional property specifying when heavy goods vehicle truck access is restricted. See the `hgv_time_restrictions` values list below. | |||
| * `hgv_restriction_shield_text`: optional and paired with `hgv_restriction` points with values like `5.1m`. Because the units are different per restriction an abbreviation should be provided. Values in meters can be specified with one decimal precision but value of 5.0m should be given as 5m. | |||
| * `hgv_restriction_shield_text_length`: optional. Returns length of `hgv_restriction_shield_text` as a string. Missing if `hgv_restriction_field_text` is !(0 < length < 7) or field doesn't exist | |||
There was a problem hiding this comment.
Nit, the Missing if... text should be replicated to all the other documentation changes, too.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement *shield_text_length (as string) for all the *shield_text fields, including hgv_restrictions. Added tests for all and updated docs.