Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

"New session title template" not working #92

Closed
egabrum opened this issue Jul 30, 2020 · 6 comments
Closed

"New session title template" not working #92

egabrum opened this issue Jul 30, 2020 · 6 comments
Assignees
Labels
bug implemented This feature is implemented and will be released with the next version of Tabs Aside.

Comments

@egabrum
Copy link

egabrum commented Jul 30, 2020

I'm trying the new "New session title template" feature, with and without variables, but all my session end up being named "session"

Firefox 79.0
Tabs Aside 3.4.0

@tim-we
Copy link
Owner

tim-we commented Jul 30, 2020

Hmm I cannot reproduce that, seems to be working as expected for me (and also for a friend with a different setup).
What is the template you are using?
Also just to be clear, this should only have an effect on new sessions, created after updating the title template.

@egabrum
Copy link
Author

egabrum commented Jul 31, 2020

Interesting. I just cannot get it to work.
I have tried templates with variables (Session $d.$M. - $Hh) and without (test). The sessions are created always with the same name (session).

@tim-we
Copy link
Owner

tim-we commented Jul 31, 2020

Can you try to restart the addon (disable & re-enable) or even restart Firefox?
How do you have Tabs Aside configured? (I just tested it with active sessions disabled and enabled, both work for me)

@egabrum
Copy link
Author

egabrum commented Jul 31, 2020

OK, I see now. I don't use the drop-down menu from the icon in the Extension bar. I find there are not enough options and, for the ones the are there, it's not too clear for me what they do from just the title ("Tabs aside", "Save tabs as session"). I'd prefer:
"Set all tabs aside in... > (new session/existing sessions)",
"Save all tabs in... > (new session/existing sessions)",
"Set selected tabs aside in... > (new session/existing sessions)",
"Save selected tabs in... > (new session/existing sessions)"

...but this is a different issue.

The problem here is that I use a different path:
Select 1 or more tabs > Right click > Tabs Aside! > [...] > create new session.

Following this path, the title is always 'session'

@tim-we tim-we self-assigned this Jul 31, 2020
@tim-we tim-we added the bug label Jul 31, 2020
tim-we added a commit that referenced this issue Jul 31, 2020
@tim-we
Copy link
Owner

tim-we commented Jul 31, 2020

Thanks for submitting this bug. I just committed a fix. The fix will be included in the next update.

@tim-we tim-we added the implemented This feature is implemented and will be released with the next version of Tabs Aside. label Jul 31, 2020
@tim-we
Copy link
Owner

tim-we commented Aug 3, 2020

The update (3.5.0) is now live.

@tim-we tim-we closed this as completed Aug 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug implemented This feature is implemented and will be released with the next version of Tabs Aside.
Projects
None yet
Development

No branches or pull requests

2 participants