Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Allows events like lottieAnimationStart to fire when used in a Capacitor project #438

Merged
merged 5 commits into from
Jun 26, 2022

Conversation

dtarnawsky
Copy link
Contributor

@dtarnawsky dtarnawsky commented May 23, 2022

This closes #368

@dtarnawsky dtarnawsky requested a review from timbru31 as a code owner May 23, 2022 14:40
@timbru31
Copy link
Owner

Interesting - calling the parent(?) view yields in a usable WebView engine? 👍

@dtarnawsky
Copy link
Contributor Author

Updated to use the call:
(webView.getView() as WebView).evaluateJavascript
rather than:
webView.engine.evaluateJavascript

This allows the code to work on both Cordova and Capacitor projects and was tested with:
Cordova Sample
and
Capacitor Sample

@dtarnawsky dtarnawsky mentioned this pull request May 29, 2022
3 tasks
@timbru31
Copy link
Owner

Thanks again!
I'll plan to make two new releases soon (one with the fix, one with the upgrade to lottie-android's new major)

@timbru31 timbru31 merged commit b537de0 into timbru31:master Jun 26, 2022
@dtarnawsky
Copy link
Contributor Author

Hey @timbru31, thanks for all the work on the plugin, there are a lot of people excited for an updated release. I noticed Simon Grim just posted a youtube tutorial on this yesterday! link here

@timbru31
Copy link
Owner

@dtarnawsky Neat <3, thanks for the hint. Definitely going to watch that video!
I'm currently a bit overloaded with two jobs - but OSS maintenance made it to the higher ranks of my free time prioritization (as it nearly stalled). Hopefully I can push something out by the end of the week.

@GimpMaster
Copy link

Hello @timbru31 - Just curious if you are going to do a new release with this fix in?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Crashes On Launch
3 participants