Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix docker build #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jheaff1
Copy link

@jheaff1 jheaff1 commented Sep 14, 2022

Building a docker image using the Dockerfile currently fails. This PR corrects the Dockerfile and package.json so that the Docker build is successful

@sibelle-labs
Copy link

working for me at 07.02.2023. thanjs

@dougbreaux
Copy link

@vpp any chance of reviewing this? I'm hitting similar issues

@dougbreaux
Copy link

@jheaff1 maybe you can also merge over the one commit this is now behind the main branch?

@jheaff1 jheaff1 force-pushed the fix_docker_build branch from 2743a71 to 8bd20af Compare July 27, 2023 14:34
@jheaff1 jheaff1 force-pushed the fix_docker_build branch from 8bd20af to 60c055a Compare July 27, 2023 14:35
@jheaff1
Copy link
Author

jheaff1 commented Jul 27, 2023

@jheaff1 maybe you can also merge over the one commit this is now behind the main branch?

done

@dougbreaux
Copy link

Using above branch, I got much further, but still eventually a build error. (Also, after many npm deprecation warnings.)

timeoff-build.log

@vnurkov
Copy link

vnurkov commented Aug 14, 2023

hey @dougbreaux, have you found the fix ? I had the same issue. Turns out it was caused by the version of python3 (3.11) which comes in alpine:latest. I downgraded the base alpine image to 3.15 (instead of latest) and the build went through.

What I mean is this line -> FROM alpine:3.15 as dependencies instead of FROM alpine:latest as dependencies and also further down in the dockerfile, FROM alpine:3.15 instead of FROM alpine:latest

Hope this helps !

Cheers!

@vpp
Copy link
Member

vpp commented Aug 14, 2023

Thank you guys for looking into this issue.

I think we just need to "freeze" the refernce at 3.5 for now.

I'll look into it soon.

@dougbreaux
Copy link

@vpp any update on this?

@dougbreaux
Copy link

FWIW, I just played around with a local build of my own and got it building and nominally running with very minimal package.json changes.

#567

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants