This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Fix Docker compose example #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debovema
requested review from
paulfantom and
VineethReddy02
and removed request for
a team
|
|
paulfantom
approved these changes
Apr 20, 2022
|
The environment variable is no longer required since this is enabled by default now. I took the liberty to tweaked a little your PR to include the other improvements to the docker-compose file. Thanks for the PR @debovema |
auto-merge was automatically disabled
October 21, 2022 13:59
Rebase failed
|
Do you want me to rebase ? |
alejandrodnm
force-pushed
the
fix-docker-compose
branch
from
d7e205c to
8f27b79
Compare
|
@debovema Sorry I just saw your message. I've just rebased and pushed |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the dependency between jaeger and promscale on the docker-compose example.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: