This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add histogram to track number samples/metadata/span sent per request #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
force-pushed
the
metric-for-samples-per-send
branch
from
d028f46 to
cb58cbc
Compare
niksajakovljevic
approved these changes
Dec 15, 2022
|
@niksajakovljevic @cevian @paulfantom I've also added heatmap panel to visualize newly added histogram. Please check. |
alejandrodnm
approved these changes
Dec 19, 2022
This commit also removes the metric promscale_ingest_items_received_total which is not used anywhere and the same information can be now obtained using the newly introduced `promscale_ingest_items_received_*` histogram metric. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
arajkumar
force-pushed
the
metric-for-samples-per-send
branch
from
4151268 to
73b749b
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also removes the metric promscale_ingest_items_received_total which is not used anywhere and the same information can be now obtained using the newly introduced
promscale_ingest_items_received_*histogram metric.Signed-off-by: Arunprasad Rajkumar ar.arunprasad@gmail.com
This is how it looks on Promscale dashboard
TODO
[ ] Alerting? - I'm not sure how feasible it would be when considering low ingestion use cases.Description
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: