Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

wait_till_presnese: Name is weird and should have verbose=False #93

Closed
gyger opened this issue Sep 12, 2019 · 5 comments
Closed

wait_till_presnese: Name is weird and should have verbose=False #93

gyger opened this issue Sep 12, 2019 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@gyger
Copy link
Contributor

gyger commented Sep 12, 2019

I think the Name is a spelling mistake and it would be nice to have a verbose parameter for this function.

linzuzeng added a commit that referenced this issue Sep 19, 2019
@linzuzeng
Copy link
Member

Thanks. But I think the name is still weird after correcting the typo. Users can't guess what it is doing from its name.

Could you maybe suggest a better name?

@linzuzeng linzuzeng added bug Something isn't working enhancement New feature or request labels Sep 19, 2019
@Cyberfly100
Copy link
Contributor

In commit c7978, I changed the name from wait_till_presence to wait_for_data. I also corrected a typo in a variable name inside the function.
Still has to be tested.

@linzuzeng
Copy link
Member

I think it is better. We also need to update the documentation before close the issue.

@Cyberfly100
Copy link
Contributor

We were also considering await instead of wait_for, but await typically returns data already. I updated the documentation with the new name and the verbose argument.

@Cyberfly100
Copy link
Contributor

tested, it works.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants