Add support for terminating active SOL sessions #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevweiss
force-pushed
the
terminate-sol
branch
from
a9cb436 to
105270e
Compare
Callisto13
reviewed
Jan 19, 2024
zevweiss
force-pushed
the
terminate-sol
branch
from
105270e to
f877049
Compare
chrisdoherty4
requested review from
jacobweinstock and
joelrebel
and removed request for
Callisto13
chrisdoherty4
previously approved these changes
Jan 23, 2024
zevweiss
force-pushed
the
terminate-sol
branch
from
f877049 to
77d82f5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 81.87% 82.29% +0.42%
==========================================
Files 9 9
Lines 491 514 +23
==========================================
+ Hits 402 423 +21
- Misses 75 76 +1
- Partials 14 15 +1 ☔ View full report in Codecov by Sentry. |
joelrebel
previously approved these changes
Jan 25, 2024
Thanks to Claudia for dealing with the go tooling problems for me... Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Note that this includes some unrelated changes in the generated code due, I gather, to my versions of the protoc tools differing from the ones that generated the existing versions. Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
zevweiss
force-pushed
the
terminate-sol
branch
from
77d82f5 to
ed39ec9
Compare
|
Updated to use new 2.2.1 tag of bmclib instead of a commit hash. |
joelrebel
approved these changes
Jan 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These patches add a DeactivateSOL request to the grpc API, which terminates an active SOL session for a given server using the method of the same name recently added to bmclib.
Why is this needed
Active SOL sessions may at times need to be forcefully ended so as to enforce proper access control.
How Has This Been Tested?
I started an an SOL session through a local BMC via
ipmitool sol activateand a pbnj service viago run main.go server. Upon usingevansto call theDeactivateSOLmethod, I observed that the SOL session was successfully terminated.How are existing users impacted? What migration steps/scripts do we need?
There should be no impact to existing users, as no existing behavior is changed.
Checklist:
I have: