Add get systemeventlog support #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Burns <mburns@equinix.com>
…d and regenerated protobufs to reflect. Some tests to make codecov happy. Signed-off-by: Matthew Burns <mburns@equinix.com>
Signed-off-by: Matthew Burns <mburns@equinix.com>
mattcburns
force-pushed
the
get-systemeventlog
branch
from
d976a7a to
5d02146
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage ? 74.82%
=======================================
Files ? 9
Lines ? 584
Branches ? 0
=======================================
Hits ? 437
Misses ? 132
Partials ? 15 ☔ View full report in Codecov by Sentry. |
mattcburns
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for getting the system event log (sel) via grpc and command line.
client.go:
SystemEventLog - Returns a slice of SystemEventLogEntry with an opinionated format (ID, Timestamp, Description, Message)
SystemEventLogRaw - Returns a blob of text that is the raw response from the BMC. (Log)
Why is this needed
Implements functionality added to bmclib so that SEL events can be captured.
Fixes: #
How Has This Been Tested?
Tests are added and pass.
How are existing users impacted? What migration steps/scripts do we need?
No migrations.
Checklist:
I have: