Skip to content

Add warning about using pickle during loading #1346

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Aug 4, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look #1320.

Closing issues

Closes #1320.

@Mr-Geekman Mr-Geekman self-assigned this Aug 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #1346 (7d43e57) into master (9824888) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1346   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         204      204           
  Lines       12687    12687           
=======================================
  Hits        11309    11309           
  Misses       1378     1378           
Files Changed Coverage Δ
etna/auto/runner/local.py 100.00% <ø> (ø)
etna/core/mixins.py 95.90% <ø> (ø)
etna/core/utils.py 97.56% <ø> (ø)
etna/ensembles/mixins.py 100.00% <ø> (ø)
etna/experimental/classification/base.py 100.00% <ø> (ø)
etna/pipeline/mixins.py 99.15% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@github-actions github-actions bot temporarily deployed to pull request August 4, 2023 09:15 Inactive
@Mr-Geekman Mr-Geekman requested a review from martins0n August 7, 2023 07:49
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have pickle here for examle

def load(path: str, *args, **kwargs):

@github-actions github-actions bot temporarily deployed to pull request August 7, 2023 14:34 Inactive
@Mr-Geekman Mr-Geekman requested a review from martins0n August 7, 2023 14:40
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot temporarily deployed to pull request August 7, 2023 16:45 Inactive
@Mr-Geekman Mr-Geekman merged commit db6b358 into master Aug 8, 2023
@Mr-Geekman Mr-Geekman deleted the issue-1320 branch August 8, 2023 05:59
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning about using pickle during loading
3 participants