New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

APDS9960 refactor #631

Draft

soypat wants to merge 2 commits into release from apds9960-redesign

Contributor

soypat commented Dec 26, 2023

PTAL @deadprogram @alankrantas @aykevl

Changes:

Remove heap allocations
Handle all errors
Much more idiomatic status and enable config setting/getting
idiomatic transaction based I2C error handling
simplify some parts of code.
Change ~ character in comments (rendered as strikethrough in newer versions of gopls)

Still WIP: needs testing on my side.

soypat added 2 commits

December 26, 2023 04:35


          change how APDS is interacted with at a I/O level; eliminate heap allocs

5dfacc3


          remove last traces of legacy I2C calls

ca37c1c

Contributor Author

soypat commented Dec 26, 2023

So it turns out what I have here is not an APDS9960, but rather an APDS9930 🤦 - guess I won't be able to test.

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet