Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to Docsy v0.10.0 #407

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Update to Docsy v0.10.0 #407

merged 1 commit into from
Jun 14, 2024

Conversation

aykevl
Copy link
Member

@aykevl aykevl commented Jun 12, 2024

This adds support for light/dark mode, which I've waited for for a while. (I wish we could just make it automatic without menu entry, but this is already better than nothing).

There are a few small visual changes, which I think are generally an improvement:

  • Buttons are more square.
  • Links now have underscores, for accessibility reasons.
  • The ellipsis after "Read more..." on the home page is gone.
  • The copyright in the footer has changed slightly.

I did a quick browse through the website and couldn't find any breaking changes.

This adds support for light/dark mode, which I've waited for for a
while. (I wish we could just make it automatic without menu entry, but
this is already better than nothing).

There are a few small visual changes, which I think are generally an
improvement:

  - Buttons are more square.
  - Links now have underscores, for accessibility reasons.
  - The ellipsis after "Read more..." on the home page is gone.
  - The copyright in the footer has changed slightly.

I did a quick browse through the website and couldn't find any breaking
changes.
@aykevl
Copy link
Member Author

aykevl commented Jun 12, 2024

And now it actually builds, after a few changes.
It looks like it uses a rather old build environment, @deadprogram do you know anything about that? I had to pick a different Go version because by default it would use Go 1.12.

@aykevl aykevl mentioned this pull request Jun 12, 2024
@deadprogram
Copy link
Member

We need to update the netlify.toml file:

I think this is what we need to have in there:

[build.environment]
  HUGO_VERSION = "0.127.0"
  GO_VERSION = "1.21"
  NODE_VERSION = "v20.x"

@aykevl
Copy link
Member Author

aykevl commented Jun 13, 2024

@deadprogram I mean the build image: https://docs.netlify.com/configure-builds/overview/#build-image-selection
Apparently this can be configured from the web UI somewhere.

@deadprogram
Copy link
Member

I think we are already using the latest image:

image

@aykevl
Copy link
Member Author

aykevl commented Jun 13, 2024

Oh, okay. I think I saw Go 1.12 in there, which is kinda old, but 20.04 ships Go 1.13 so it's not that far off.
Then I think there's nothing we need to update.

(That means this PR is ready for merge in my opinion).

@deadprogram
Copy link
Member

OK, now merging. Thanks for the update @aykevl

@deadprogram deadprogram merged commit 58af802 into dev Jun 14, 2024
4 checks passed
@deadprogram deadprogram deleted the docsy-v0.10.0 branch June 14, 2024 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants