runtime: avoid an allocation in (*time.Timer).Reset #4890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
approved these changes
May 9, 2025
eliasnaur
force-pushed
the
push-oskwypvzoquy
branch
from
834ec50 to
df1f8b7
Compare
|
Good point. PTAL. |
|
Looks good now, thanks for the improvement @eliasnaur and to @dgryski for review/feedback. Now merging. |
aykevl
reviewed
May 21, 2025
| @@ -117,11 +117,11 @@ func addTimer(tim *timerNode) { | |||
|
|
|||
| // removeTimer is the implementation of time.stopTimer. It removes a timer from | |||
| // the timer queue, returning true if the timer is present in the timer queue. | |||
There was a problem hiding this comment.
This comment is now incorrect: it doesn't return a bool anymore.
eliasnaur
added a commit
to eliasnaur/tinygo
that referenced
this pull request
May 21, 2025
I forgot to change the comment in PR tinygo-org#4890.
deadprogram
pushed a commit
that referenced
this pull request
May 22, 2025
I forgot to change the comment in PR #4890.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.