fix jest-puppeteer globals import #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow what awesome service! I didn't think to check there would be a breaking change (given the minor rev) but this makes sense. So cool!!! |
|
You're welcome ! The follow-up is part of contributing as well 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains a fix to import the
jest-puppeteerglobals intest/e2e/common.tsand reenable types resolution.The fix is in branch
my_branch.How did you test this change?
The end to end test suite passes 100%.
I had to do a
npm iand updatepackage-lock.jsonsincenpm cierrored. I don't know if the newpackage-lock.jsonshould be merged or discarded.