Remove userland/module check #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Smart <derek@grindaga.com>
Signed-off-by: Derek Smart <derek@grindaga.com>
Signed-off-by: Derek Smart <derek@grindaga.com>
robertericreeves
approved these changes
Aug 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since updating to ZFS 2.0+, we have been updating kernel module frequently. This has lead to some versioning issues between pre-compiled ZFS kernel modules and the installed version of the ZFS userland in titan server. This check was originally put in place to make sure the kernel modules don't outpace the userland because it was thought that it would be okay, it wasn't tested. It is not tested. The e2e tests have confirmed the following scenarios:
Looking at the roadmap for ZFS, it is very likely to remain in the 2.1 branch for a few years. I feel this userland check should not be an issue until a major version release for ZFS.