Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for all datatypes #46

Open
wants to merge 112 commits into
base: master
Choose a base branch
from
Open

Support for all datatypes #46

wants to merge 112 commits into from

Conversation

Pubaluba
Copy link

hi, have a look at this fork rebuild

maybe you can use for your own code

have fun

Pubaluba added 30 commits August 7, 2023 00:22
thes are files made aut of multiple forks and repos.
cleaned up for my needs.

updated Readme !
reverted back to "localhost" as default broker.
removed "modbus4mqtt version ** connected " message
removed version file and made it EW.0.7
removed docker 
added a unix.service file with wildcard config for activating an service for known yaml in directory /etc/modbus4mqtt/
updated installation
added installation of service unit
Double intergrated to Python float_type 
register count Same as int64
Added double, >double, <double, double_le, double_be
To valid datatypes and added number If registers
Bugfix Double Registercount
Added --loop Option to disable Infinite loop
it can be used to start oneshot with cron to ensure correct timestamp of data
one extra comma removed
@pep8speaks
Copy link

pep8speaks commented Jan 2, 2024

Hello @Pubaluba! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:1: E302 expected 2 blank lines, found 1
Line 19:3: E111 indentation is not a multiple of four
Line 20:3: E111 indentation is not a multiple of four
Line 21:3: E111 indentation is not a multiple of four
Line 23:7: E111 indentation is not a multiple of four
Line 25:7: E111 indentation is not a multiple of four
Line 27:3: E111 indentation is not a multiple of four
Line 28:3: E111 indentation is not a multiple of four
Line 30:7: E111 indentation is not a multiple of four
Line 30:14: E201 whitespace after '['
Line 30:18: E202 whitespace before ']'
Line 33:3: E111 indentation is not a multiple of four
Line 36:15: E201 whitespace after '{'
Line 54:1: W293 blank line contains whitespace
Line 55:25: E201 whitespace after '{'
Line 58:7: E111 indentation is not a multiple of four
Line 59:7: E111 indentation is not a multiple of four
Line 61:7: E111 indentation is not a multiple of four
Line 62:7: E111 indentation is not a multiple of four
Line 63:7: E111 indentation is not a multiple of four
Line 66:11: E111 indentation is not a multiple of four
Line 67:7: E111 indentation is not a multiple of four
Line 68:1: W293 blank line contains whitespace
Line 76:90: E201 whitespace after '{'
Line 77:53: E124 closing bracket does not match visual indentation
Line 92:11: E111 indentation is not a multiple of four
Line 93:11: E111 indentation is not a multiple of four
Line 97:21: E201 whitespace after '('
Line 97:25: E202 whitespace before ')'
Line 98:11: E111 indentation is not a multiple of four
Line 102:11: E111 indentation is not a multiple of four
Line 126:7: E111 indentation is not a multiple of four
Line 129:7: E111 indentation is not a multiple of four
Line 131:7: E111 indentation is not a multiple of four
Line 132:7: E111 indentation is not a multiple of four
Line 135:7: E111 indentation is not a multiple of four
Line 156:1: W293 blank line contains whitespace
Line 158:15: E111 indentation is not a multiple of four
Line 159:29: E201 whitespace after '('
Line 159:41: E202 whitespace before ')'
Line 160:15: E111 indentation is not a multiple of four
Line 164:19: E111 indentation is not a multiple of four
Line 165:15: E111 indentation is not a multiple of four
Line 167:19: E111 indentation is not a multiple of four
Line 170:15: E111 indentation is not a multiple of four
Line 171:19: E111 indentation is not a multiple of four
Line 171:46: E201 whitespace after '('
Line 174:15: E111 indentation is not a multiple of four
Line 175:19: E111 indentation is not a multiple of four
Line 177:19: E111 indentation is not a multiple of four
Line 178:19: E111 indentation is not a multiple of four
Line 179:1: W293 blank line contains whitespace
Line 180:15: E114 indentation is not a multiple of four (comment)
Line 181:15: E111 indentation is not a multiple of four
Line 182:19: E114 indentation is not a multiple of four (comment)
Line 183:19: E111 indentation is not a multiple of four
Line 184:23: E111 indentation is not a multiple of four
Line 185:15: E114 indentation is not a multiple of four (comment)
Line 186:15: E111 indentation is not a multiple of four
Line 187:15: E114 indentation is not a multiple of four (comment)
Line 188:15: E111 indentation is not a multiple of four
Line 190:15: E111 indentation is not a multiple of four
Line 192:15: E111 indentation is not a multiple of four
Line 193:1: W293 blank line contains whitespace
Line 197:19: E111 indentation is not a multiple of four
Line 217:19: E111 indentation is not a multiple of four
Line 224:71: E202 whitespace before ')'
Line 227:11: E111 indentation is not a multiple of four
Line 242:121: E501 line too long (129 > 120 characters)
Line 314:15: E111 indentation is not a multiple of four
Line 320:19: E111 indentation is not a multiple of four
Line 324:19: E111 indentation is not a multiple of four
Line 327:121: E501 line too long (133 > 120 characters)
Line 342:11: E111 indentation is not a multiple of four
Line 342:32: E201 whitespace after '{'
Line 342:45: E202 whitespace before '}'
Line 345:11: E114 indentation is not a multiple of four (comment)
Line 346:11: E111 indentation is not a multiple of four
Line 346:121: E501 line too long (128 > 120 characters)
Line 347:11: E111 indentation is not a multiple of four
Line 350:11: E111 indentation is not a multiple of four
Line 351:11: E111 indentation is not a multiple of four
Line 353:121: E501 line too long (137 > 120 characters)
Line 357:62: E261 at least two spaces before inline comment
Line 363:15: E111 indentation is not a multiple of four
Line 365:15: E111 indentation is not a multiple of four
Line 367:15: E111 indentation is not a multiple of four
Line 369:15: E111 indentation is not a multiple of four
Line 371:15: E111 indentation is not a multiple of four
Line 373:15: E111 indentation is not a multiple of four
Line 384:49: E251 unexpected spaces around keyword / parameter equals
Line 384:51: E251 unexpected spaces around keyword / parameter equals
Line 384:67: E251 unexpected spaces around keyword / parameter equals
Line 384:69: E251 unexpected spaces around keyword / parameter equals
Line 390:13: E117 over-indented
Line 417:121: E501 line too long (131 > 120 characters)
Line 419:1: E304 blank lines found after function decorator
Line 429:8: E111 indentation is not a multiple of four
Line 431:8: E111 indentation is not a multiple of four

Line 16:17: E201 whitespace after '['
Line 16:36: E202 whitespace before ']'
Line 18:1: E302 expected 2 blank lines, found 1
Line 22:1: E302 expected 2 blank lines, found 1
Line 22:44: E201 whitespace after '['
Line 22:60: E202 whitespace before ']'
Line 23:3: E111 indentation is not a multiple of four
Line 24:1: W293 blank line contains whitespace
Line 25:3: E111 indentation is not a multiple of four
Line 27:1: W293 blank line contains whitespace
Line 28:3: E111 indentation is not a multiple of four
Line 29:3: E111 indentation is not a multiple of four
Line 31:7: E111 indentation is not a multiple of four
Line 33:1: W293 blank line contains whitespace
Line 34:3: E111 indentation is not a multiple of four
Line 35:3: E111 indentation is not a multiple of four
Line 37:7: E111 indentation is not a multiple of four
Line 39:7: E111 indentation is not a multiple of four
Line 41:1: W293 blank line contains whitespace
Line 42:1: E302 expected 2 blank lines, found 1
Line 67:121: E501 line too long (138 > 120 characters)
Line 70:121: E501 line too long (138 > 120 characters)
Line 76:7: E111 indentation is not a multiple of four
Line 77:1: W293 blank line contains whitespace
Line 82:17: E221 multiple spaces before operator
Line 83:19: E221 multiple spaces before operator
Line 85:19: E221 multiple spaces before operator
Line 87:15: E111 indentation is not a multiple of four
Line 89:15: E111 indentation is not a multiple of four
Line 96:40: E128 continuation line under-indented for visual indent
Line 97:40: E128 continuation line under-indented for visual indent
Line 97:49: E231 missing whitespace after ','
Line 97:78: E203 whitespace before ','
Line 98:40: E128 continuation line under-indented for visual indent
Line 100:17: E225 missing whitespace around operator
Line 101:17: E225 missing whitespace around operator
Line 108:51: E128 continuation line under-indented for visual indent
Line 109:51: E128 continuation line under-indented for visual indent
Line 129:11: E111 indentation is not a multiple of four
Line 133:1: W293 blank line contains whitespace
Line 140:7: E111 indentation is not a multiple of four
Line 141:7: E111 indentation is not a multiple of four
Line 144:1: W293 blank line contains whitespace
Line 146:7: E111 indentation is not a multiple of four
Line 146:17: E201 whitespace after '['
Line 147:7: E111 indentation is not a multiple of four
Line 151:11: E111 indentation is not a multiple of four
Line 153:15: E111 indentation is not a multiple of four
Line 154:15: E111 indentation is not a multiple of four
Line 155:11: E111 indentation is not a multiple of four
Line 156:27: E201 whitespace after '('
Line 156:29: E201 whitespace after '('
Line 156:43: E202 whitespace before ')'
Line 156:45: E202 whitespace before ')'
Line 157:11: E111 indentation is not a multiple of four
Line 158:11: E111 indentation is not a multiple of four
Line 159:7: E111 indentation is not a multiple of four
Line 163:11: E111 indentation is not a multiple of four
Line 163:25: E201 whitespace after '('
Line 163:27: E201 whitespace after '('
Line 163:41: E202 whitespace before ')'
Line 163:43: E202 whitespace before ')'
Line 164:11: E111 indentation is not a multiple of four
Line 167:7: E111 indentation is not a multiple of four
Line 168:23: E201 whitespace after '('
Line 168:25: E201 whitespace after '('
Line 168:39: E202 whitespace before ')'
Line 168:41: E202 whitespace before ')'
Line 170:7: E111 indentation is not a multiple of four
Line 172:1: W293 blank line contains whitespace
Line 173:5: E303 too many blank lines (2)
Line 177:1: W293 blank line contains whitespace
Line 178:18: E201 whitespace after '('
Line 178:31: E202 whitespace before ')'
Line 179:15: E111 indentation is not a multiple of four
Line 180:19: E111 indentation is not a multiple of four
Line 181:19: E111 indentation is not a multiple of four
Line 182:19: E111 indentation is not a multiple of four
Line 183:23: E111 indentation is not a multiple of four
Line 184:23: E111 indentation is not a multiple of four
Line 185:19: E114 indentation is not a multiple of four (comment)
Line 186:19: E111 indentation is not a multiple of four
Line 187:15: E111 indentation is not a multiple of four
Line 188:19: E111 indentation is not a multiple of four
Line 189:19: E111 indentation is not a multiple of four
Line 196:121: E501 line too long (140 > 120 characters)
Line 206:37: E231 missing whitespace after ','
Line 224:121: E501 line too long (132 > 120 characters)
Line 248:121: E501 line too long (132 > 120 characters)
Line 251:121: E501 line too long (158 > 120 characters)
Line 252:121: E501 line too long (125 > 120 characters)
Line 253:121: E501 line too long (124 > 120 characters)
Line 256:34: E227 missing whitespace around bitwise or shift operator
Line 279:9: E722 do not use bare 'except'
Line 281:121: E501 line too long (144 > 120 characters)
Line 283:1: E305 expected 2 blank lines after class or function definition, found 1
Line 283:16: E201 whitespace after '['
Line 283:34: E203 whitespace before ','
Line 284:15: E128 continuation line under-indented for visual indent
Line 284:34: E203 whitespace before ','
Line 285:15: E128 continuation line under-indented for visual indent
Line 285:34: E203 whitespace before ','
Line 286:15: E128 continuation line under-indented for visual indent
Line 286:24: E203 whitespace before ','
Line 287:15: E128 continuation line under-indented for visual indent
Line 287:37: E203 whitespace before ','
Line 288:15: E128 continuation line under-indented for visual indent
Line 288:37: E203 whitespace before ','
Line 289:15: E128 continuation line under-indented for visual indent
Line 289:25: E203 whitespace before ','
Line 290:15: E128 continuation line under-indented for visual indent
Line 290:39: E203 whitespace before ','
Line 291:15: E128 continuation line under-indented for visual indent
Line 292:15: E124 closing bracket does not match visual indentation
Line 294:1: E302 expected 2 blank lines, found 1
Line 303:21: E211 whitespace before '('
Line 305:1: E302 expected 2 blank lines, found 1
Line 311:21: E211 whitespace before '('
Line 313:1: E302 expected 2 blank lines, found 1
Line 315:17: E201 whitespace after '('
Line 316:7: E111 indentation is not a multiple of four
Line 317:17: E201 whitespace after '('
Line 318:7: E111 indentation is not a multiple of four
Line 319:17: E201 whitespace after '('
Line 319:38: E202 whitespace before ')'
Line 320:7: E111 indentation is not a multiple of four
Line 321:19: E201 whitespace after '('
Line 321:40: E202 whitespace before ')'
Line 322:7: E111 indentation is not a multiple of four
Line 323:19: E201 whitespace after '('
Line 323:42: E202 whitespace before ')'
Line 324:7: E111 indentation is not a multiple of four
Line 325:19: E201 whitespace after '('
Line 325:42: E202 whitespace before ')'
Line 326:7: E111 indentation is not a multiple of four
Line 328:7: E111 indentation is not a multiple of four
Line 329:7: E111 indentation is not a multiple of four
Line 329:34: E231 missing whitespace after ','
Line 329:50: E231 missing whitespace after ','
Line 331:1: E302 expected 2 blank lines, found 1
Line 333:17: E201 whitespace after '('
Line 333:25: E202 whitespace before ')'
Line 334:7: E111 indentation is not a multiple of four
Line 335:17: E201 whitespace after '('
Line 336:7: E111 indentation is not a multiple of four
Line 337:17: E201 whitespace after '('
Line 337:38: E202 whitespace before ')'
Line 338:7: E111 indentation is not a multiple of four
Line 339:19: E201 whitespace after '('
Line 339:40: E202 whitespace before ')'
Line 340:7: E111 indentation is not a multiple of four
Line 341:19: E201 whitespace after '('
Line 341:42: E202 whitespace before ')'
Line 342:7: E111 indentation is not a multiple of four
Line 343:19: E201 whitespace after '('
Line 343:42: E202 whitespace before ')'
Line 344:7: E111 indentation is not a multiple of four
Line 346:7: E111 indentation is not a multiple of four
Line 347:7: E114 indentation is not a multiple of four (comment)
Line 348:7: E114 indentation is not a multiple of four (comment)
Line 349:7: E111 indentation is not a multiple of four
Line 349:53: E231 missing whitespace after ','
Line 349:69: E231 missing whitespace after ','

Comment last updated at 2024-06-04 14:56:54 UTC

raised version a little bit
Added threading 4 polling
added set_topic only as an example
added desciption for the Thread-Feature
limit paho-mqtt version
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants