Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

TestModel.scalemodel fails for single-charge systems #21

Closed
tkemmer opened this issue Feb 24, 2025 · 0 comments · Fixed by #25
Closed

TestModel.scalemodel fails for single-charge systems #21

tkemmer opened this issue Feb 24, 2025 · 0 comments · Fixed by #25
Assignees
@tkemmer
Labels
bug
Milestone
v1.4

Comments

@tkemmer
Copy link
Owner

tkemmer commented Feb 24, 2025

For single-charge systems, rescaling results in a division by zero:

julia> TestModel.scalemodel([Charge(ones(3), 1.0)], 1.0)
1-element Vector{Charge{Float64}}:
 Charge{Float64}(pos = [NaN, NaN, NaN], val = 1.0)
@tkemmer tkemmer added the bug label Feb 24, 2025
@tkemmer tkemmer added this to the v1.4 milestone Feb 24, 2025
@tkemmer tkemmer self-assigned this Feb 24, 2025
@tkemmer tkemmer mentioned this issue Feb 24, 2025
Merged
tkemmer added a commit that referenced this issue Feb 25, 2025
@tkemmer
TestModel: fix scalemodel w/ single-charge models
af9fa78 
Fixes: #21
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tkemmer tkemmer

Labels
bug
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fixes for NonlocalXieModel1 tkemmer/NESSie.jl
1 participant
@tkemmer