Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NonlocalXieModel1: different born potential definitions used for charges (not) located at the origin #24

Closed
tkemmer opened this issue Feb 24, 2025 · 0 comments · Fixed by #25
Closed

NonlocalXieModel1: different born potential definitions used for charges (not) located at the origin #24

tkemmer opened this issue Feb 24, 2025 · 0 comments · Fixed by #25
Assignees
@tkemmer
Labels
bug
Milestone
v1.4

Comments

@tkemmer
Copy link
Owner

tkemmer commented Feb 24, 2025

When charges are located at the origin, the potential for the affected charge is effectively a Born potential. However, we use a different definition of Born potentials as the reference paper for the test model, leading to incorrect overall potentials in such cases.

This issue has been hidden by #23 so far.
@tkemmer tkemmer added the bug label Feb 24, 2025
@tkemmer tkemmer added this to the v1.4 milestone Feb 24, 2025
@tkemmer tkemmer self-assigned this Feb 24, 2025
@tkemmer tkemmer mentioned this issue Feb 24, 2025
Merged
tkemmer added a commit that referenced this issue Feb 25, 2025
@tkemmer
TestModel: fix NonlocalXieModel potentials w/ charges in the origin
f39e4e1 
Fixes: #24
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tkemmer tkemmer

Labels
bug
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fixes for NonlocalXieModel1 tkemmer/NESSie.jl
1 participant
@tkemmer