Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

foreach broken on Julia master due to method matching changes #19

Closed
rdeits opened this issue Jan 26, 2018 · 0 comments · Fixed by #20
Closed

foreach broken on Julia master due to method matching changes #19

rdeits opened this issue Jan 26, 2018 · 0 comments · Fixed by #20

Comments

@rdeits
Copy link
Contributor

rdeits commented Jan 26, 2018

The foreach implementation here relies on the behavior that was removed in JuliaLang/julia#23117 (just like StaticArrays did), so we'll have to find a similar solution. I've posted on discourse https://discourse.julialang.org/t/expressing-at-least-one-of-this-type-on-julia-master/8624 in case anyone has a clever idea for how to get around this.
rdeits added a commit to rdeits/TypeSortedCollections.jl that referenced this issue Jan 26, 2018
@rdeits
Require map! and foreach to take a TSC as their first source argument
f7d5716 
This makes map! and foreach slightly less useful, but it's a simple way
to fix tkoolen#19 on Julia master.

The more correct solution would be to implement something like the way
BroadcastStyle works for broadcast(), but that's a much bigger change.
@rdeits rdeits mentioned this issue Jan 26, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rdeits