Remove unnecessary activation events #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever I open the extension, vscode complains that commands don't need to be added to activationEvents. This commit fixes that terrible oversight. Signed-off-by: Hillel <h@hillelwayne.com>
|
For the record, there was a bug where the TLA+ commands of the extension wouldn’t appear unless some .tla file was opened in the editor. Consequently, it became impossible to use the REPL alone. However, I don’t seem to be able to reproduce this issue anymore. Therefore, I’m leaving it here just because this issue is about activation and in case the problem resurfaces. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I open the extension, vscode complains that commands don't need to be added to activationEvents.
This PR fixes that terrible oversight. The extension works normally without them.