Fix missing render path error

[marchersimon]

I tried fixing another uncaught error, when running tldr --render without a path. Insead of getting

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string or an instance of Buffer or URL. Received type boolean (true)
    at readFile (node:fs:351:10)
    at go$readFile (/usr/lib/node_modules/tldr/node_modules/graceful-fs/graceful-fs.js:118:14)
    at Object.readFile (/usr/lib/node_modules/tldr/node_modules/graceful-fs/graceful-fs.js:115:12)
    at /usr/lib/node_modules/tldr/node_modules/universalify/index.js:10:14
    at new Promise (<anonymous>)
    at Object.readFile (/usr/lib/node_modules/tldr/node_modules/universalify/index.js:7:14)
    at Tldr.render (/usr/lib/node_modules/tldr/lib/tldr.js:76:15)
    at Object.<anonymous> (/usr/lib/node_modules/tldr/bin/tldr:104:12)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10) {
  code: 'ERR_INVALID_ARG_TYPE'
}

I now get

/home/simon/Desktop/tldr-node-client/bin/tldr:112
    throw new MissingRenderPathError();
    ^

MissingRenderPathError: Option --render needs an argument.
    at Object.<anonymous> (/home/simon/Desktop/tldr-node-client/bin/tldr:112:11)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Function.Module._load (node:internal/modules/cjs/loader:828:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  code: 4
}

I know it's not much, but maybe a start. Feel free to close the PR if it isn't helpful.

[vladimyr]

I know it's not much, but maybe a start. Feel free to close the PR if it isn't helpful.

Quality matters more than quantity 😉 and looking from that perspective this is certainly a good effort 👍

[vladimyr]

LGTM I believe it is ready for prime time by removing draft status 😉

[marchersimon]

Do you think this can already be merged? The output is still pretty long:

Desktop/tldr-node-client/lib/tldr.js:77
      throw new MissingRenderPathError();
      ^

MissingRenderPathError: Option --render needs an argument.
    at Tldr.render (/home/simon/Desktop/tldr-node-client/lib/tldr.js:77:13)
    at Object.<anonymous> (/home/simon/Desktop/tldr-node-client/bin/tldr:111:12)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Function.Module._load (node:internal/modules/cjs/loader:828:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  code: 4
}

[marchersimon]

Any updates on this?

[agnivade]

You are welcome to merge this by yourself, or let me know, I am happy to do it.