Add win32 to platform.js #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding 'win32':'windows' key-value in the platform.js file allows to detect the system platform as part of the default configuration (for windows users). The key 'win32' is provided by the 'os' core module api.
owenvoke
approved these changes
Nov 19, 2021
navarroaxel
approved these changes
Nov 19, 2021
CleanMachine1
approved these changes
Nov 20, 2021
navarroaxel
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 'win32':'windows' key-value in the platform.js file allows to detect the system platform as part of the default configuration (for windows users). The 'win32' key is provided by the 'os' core module api.
Description
I've added a key-value pair:
"win32":"windows"inside thefoldersobject in the /lib/plaform.js file, this change allows tldr-node-client to identify the windows platform (as default configuration). It solves the issue #368 .Checklist
Please review this checklist before submitting a pull request.
npm run test:all)