Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

curl, open, powershell, wget: remove "view in older versions of tldr" #10851

Merged
merged 2 commits into from
Nov 19, 2023
Merged

curl, open, powershell, wget: remove "view in older versions of tldr" #10851

merged 2 commits into from
Nov 19, 2023

Conversation

acuteenvy
Copy link
Member

@acuteenvy acuteenvy commented Oct 5, 2023 •
edited by sebastiaanspeck
Loading

This example is only in those three pages, all others have the updated option from the current specification (-p/--platform).

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Oct 5, 2023
@kbdharun kbdharun mentioned this pull request Oct 5, 2023
Merged
5 tasks
kbdharun
kbdharun approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun
Copy link
Member

kbdharun commented Oct 5, 2023 •
edited
Loading

Update: the Node client still seems to be requiring this option. I will open a PR to update the behaviour as suggested in #10848 (comment) (there is an old unresolved PR still open for it).

@reinhart1010
Copy link
Collaborator

Hi, as the original author of these pages, I still prefer to keep it while waiting for the official Node.js client to be fixed, more on #8297.

@kbdharun kbdharun marked this pull request as draft October 5, 2023 08:27
@kbdharun
Copy link
Member

kbdharun commented Oct 5, 2023

Hi, as the original author of these pages, I still prefer to keep it while waiting for the official Node.js client to be fixed, more on #8297.

Agreed, Thanks for the info (on the other PR, I forgot the Node client doesn't use platform options)

I have marked this PR as a draft, post the change is done. I will open it back for review.

@kbdharun
Copy link
Member

kbdharun commented Oct 5, 2023

Update: Created a PR for it tldr-pages/tldr-node-client#421, let's see how it goes.

@acuteenvy
Copy link
Member Author

The stalebot was removed a couple months ago.

@kbdharun kbdharun added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 26, 2023
@sebastiaanspeck
Copy link
Member

The open page has tldr open -o osx as well.

@sebastiaanspeck sebastiaanspeck changed the title curl, wget: remove "view in older versions of tldr" curl, open, wget: remove "view in older versions of tldr" Nov 5, 2023
@github-actions github-actions bot added the translation Issues requesting translating pages from English to other languages. label Nov 5, 2023
@kbdharun kbdharun force-pushed the main branch 2 times, most recently from 5d0d9a0 to f402eee Compare November 6, 2023 08:32
@kbdharun kbdharun marked this pull request as ready for review November 19, 2023 04:56
@kbdharun
Copy link
Member

Marking this PR as open for review since the OS option has been changed to platform in our Node client.

Now, we need to remove this line across the pages.

@sebastiaanspeck
Copy link
Member

A good rebase is needed. It contains more changes than is described/expected.

@acuteenvy acuteenvy changed the title curl, open, wget: remove "view in older versions of tldr" curl, open, powershell, wget: remove "view in older versions of tldr" Nov 19, 2023
@sebastiaanspeck
Copy link
Member

Could you please delete them from translated pages as well?

@acuteenvy acuteenvy added the mass changes Changes that affect multiple pages. label Nov 19, 2023
@tldr-bot

This comment has been minimized.

# to view
kant
kant reviewed Nov 19, 2023
View reviewed changes
pages/common/open.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kant
kant reviewed Nov 19, 2023
View reviewed changes
pages/common/powershell.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbdharun kbdharun merged commit e2cc1b7 into tldr-pages:main Nov 19, 2023
kant
kant reviewed Nov 19, 2023
View reviewed changes
pages/windows/curl.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kant
kant reviewed Nov 19, 2023
View reviewed changes
pages/common/powershell.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kant
kant reviewed Nov 19, 2023
View reviewed changes
pages/windows/wget.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acuteenvy acuteenvy deleted the tldr-older-versions branch November 20, 2023 15:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kant kant kant left review comments

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

@blueskyson blueskyson Awaiting requested review from blueskyson

@einverne einverne Awaiting requested review from einverne

@leonvsc leonvsc Awaiting requested review from leonvsc leonvsc is a code owner

@IMHOJEONG IMHOJEONG Awaiting requested review from IMHOJEONG

@mebeim mebeim Awaiting requested review from mebeim

@tansiret tansiret Awaiting requested review from tansiret

@Magrid0 Magrid0 Awaiting requested review from Magrid0

@reinhart1010 reinhart1010 Awaiting requested review from reinhart1010 reinhart1010 is a code owner

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

@pixelcmtd pixelcmtd Awaiting requested review from pixelcmtd

@marchersimon marchersimon Awaiting requested review from marchersimon

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. mass changes Changes that affect multiple pages. page edit Changes to an existing page(s). translation Issues requesting translating pages from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acuteenvy @kbdharun @reinhart1010 @sebastiaanspeck @tldr-bot @kant @gutjuri