Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

client spec: fix page platform section #2859

Merged
merged 2 commits into from
Apr 1, 2019
Merged

client spec: fix page platform section #2859

merged 2 commits into from
Apr 1, 2019

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Mar 30, 2019

This updates the page platform section to match what we actually do, following a discussion with @agnivade via Gitter.

@agnivade, how to you mean that the Page Resolution section needs clarification?

@sbrl sbrl added the documentation Issues/PRs modifying the documentation. label Mar 30, 2019
@agnivade
Copy link
Member

We can add a line saying that - It is possible that due to this page resolution logic, the client may show a page which does not belong to the host platform, because a page can reside in common, and not in the host platform. So the user must not assume that a shown command is always runnable in the host platform.

There is also this issue that now we do not know exactly which platforms are supported with a command. That would need a page structure change to add metadata to specify this.

@prfcttone2
Copy link

Great idea

@sbrl sbrl merged commit fbdc06b into master Apr 1, 2019
@owenvoke owenvoke deleted the client-spec/platforms branch April 12, 2019 14:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants