Client spec: require exiting with non-zero code on missing page #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrl
reviewed
Aug 9, 2020
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
|
Are we good to merge this? |
waldyrious
approved these changes
Aug 31, 2020
waldyrious
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the specification to include a recommendation on exiting with a non-zero exit code in addition to showing an error message, which is helpful for scripts and things that may be consuming this tool.
Edit by @sbrl: Fixes #4227