Skip to content

nc: improve grammar; bring under the 8 example limit #5058

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 1, 2021

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Dec 30, 2020

This page edit is in its own PR, as I ended up making some more extensive modifications to it in addition to bringing it under the 8 example limit.

I argue that the send / receive a file examples are redundant, as they showcase existing shell functionality. The first 1 examples should cover these fine I think.

Part of #5046.

@sbrl sbrl added the page edit Changes to an existing page(s). label Dec 30, 2020
@sbrl sbrl mentioned this pull request Dec 30, 2020
7 tasks
@sbrl sbrl changed the title Page edit/nc nc: improve grammar; bring under the 8 example limit Dec 30, 2020
@bl-ue
Copy link
Contributor

bl-ue commented Jan 1, 2021

@sbrl would you do a "Rebase and merge" on this one? Or squash?

@navarroaxel navarroaxel merged commit 06b697b into master Jan 1, 2021
@navarroaxel navarroaxel deleted the page-edit/nc branch January 1, 2021 21:56
@navarroaxel
Copy link
Collaborator

@bl-ue rebase and merge if the commits are clean

@waldyrious
Copy link
Member

The first 1 examples should cover these fine

@sbrl can you clarify what you meant by this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants