-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
tldr: fix typo #6869
tldr: fix typo #6869
Conversation
Fixed typo. It seems `-o` is `--os` selection. Maybe `--update` instead of `-u` is more convenient, because old tldr-hs client on Ubuntu/Debian doesn't understand -u.
This comment has been minimized.
This comment has been minimized.
Hi @prometoys, welcome and thanks for your submission. I think you should check the client-specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch!
Thank you @prometoys for your contribution.
Apologies, as per the client-specification this is not correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, as per the client-specification this is not correct. I am using
tealdear
link, which probably is not conformant to the spec.
😆 then I will request changes to avoid merge it by mistake
Hi @navarroaxel, thanks for the link. I checked different tldr clients: tldr-hs 0.9.1 None of them understands the option |
Our official clients - Python Uses -p |
tldr-hs accepts the |
Ok, I must apologize. The tldr-hs 0.9 does understand I downloaded tldr-hs 0.9.1 yesterday, but probably after tests on different machines and different clients cand their versions onfused
This is correct, can confirm it with tldr-py 1.2.0 on fedora. I guess with tldr-py (0.7) on Ubuntu is the same problem like tldr-hs, too old versions. The node-client is recommended on tldr.org, but expects From a user perspective running Thanks for you patience (btw, I love the tldr approach) |
For tldr-node-client, see tldr-pages/tldr-node-client#337, which needs some attention |
Hi all! This thread has not had any recent activity. |
Can we close this PR since it has been discussed and is technically incorrect |
Yeah, I suggest we close this PR. If there's more to discuss about this, please open a new issue. |
this has already caused a lot of confusion (tldr-pages/tldr#6869, tldr-pages/tldr#9252 (review), …), is not standard (https://github.com/tldr-pages/tldr/blob/9ac1ffd5ca55f977da63d954788be5c463def51a/CLIENT-SPECIFICATION.md#arguments) and has already been fixed in other clients (tealdeer-rs/tealdeer#209)
Fixed typo. It seems
-o
is--os
selection.Maybe
--update
instead of-u
is more convenient, because old tldr-hs client on Ubuntu/Debian doesn't understand -u.