Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tldr: fix typo #6869

Closed
wants to merge 1 commit into from
Closed

tldr: fix typo #6869

wants to merge 1 commit into from

Conversation

prometoys
Copy link

Fixed typo. It seems -o is --os selection.

Maybe --update instead of -u is more convenient, because old tldr-hs client on Ubuntu/Debian doesn't understand -u.

Fixed typo. It seems `-o` is `--os` selection. 

Maybe `--update` instead of `-u` is more convenient, because old tldr-hs client on Ubuntu/Debian doesn't understand -u.
@CLAassistant

This comment has been minimized.

@navarroaxel
Copy link
Collaborator

Hi @prometoys, welcome and thanks for your submission. I think you should check the client-specification.

@navarroaxel navarroaxel added the page edit Changes to an existing page(s). label Oct 7, 2021
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!
Thank you @prometoys for your contribution.

@mfrw
Copy link
Member

mfrw commented Oct 7, 2021

Good Catch! Thank you @prometoys for your contribution.

Apologies, as per the client-specification this is not correct.
I am using tealdear link, which probably is not conformant to the spec.

Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, as per the client-specification this is not correct. I am using tealdear link, which probably is not conformant to the spec.

😆 then I will request changes to avoid merge it by mistake

@prometoys
Copy link
Author

Hi @navarroaxel,

thanks for the link. I checked different tldr clients:

tldr-hs 0.9.1
tldr from nmp 3.3.7
tealdeer v1.4.1 (Linux)
tldr-py 0.7.0

None of them understands the option -p. Which client accept -p ?

@CleanMachine1
Copy link
Member

Our official clients - Python

Uses -p

@MasterOdin
Copy link
Collaborator

tldr-hs accepts the -p flag per their README.

@prometoys
Copy link
Author

tldr-hs accepts the -p flag per their README.

Ok, I must apologize. The tldr-hs 0.9 does understand -p, the 0.4.0 in Ubuntu neither -o or -p.

I downloaded tldr-hs 0.9.1 yesterday, but probably after tests on different machines and different clients cand their versions onfused -p and -o myself.

Our official clients - Python
Uses -p

This is correct, can confirm it with tldr-py 1.2.0 on fedora. I guess with tldr-py (0.7) on Ubuntu is the same problem like tldr-hs, too old versions.

The node-client is recommended on tldr.org, but expects -o (Version 3.3.7).

https://github.com/tldr-pages/tldr-node-client/blob/1641dea94df3aabcd36f381dcac61a50905a36ea/bin/tldr#L25

From a user perspective running tldr tldr this situation is confusing. Maybe there should be a hint, like with update (-u)?

Thanks for you patience

(btw, I love the tldr approach)

@sbrl
Copy link
Member

sbrl commented Oct 8, 2021

For tldr-node-client, see tldr-pages/tldr-node-client#337, which needs some attention

@github-actions
Copy link

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Oct 24, 2021
@CleanMachine1
Copy link
Member

Can we close this PR since it has been discussed and is technically incorrect

@github-actions github-actions bot removed the waiting Issues/PRs with Pending response by the author. label Oct 27, 2021
@sbrl
Copy link
Member

sbrl commented Oct 28, 2021

Yeah, I suggest we close this PR. If there's more to discuss about this, please open a new issue.

@sbrl sbrl closed this Oct 28, 2021
@pixelcmtd pixelcmtd mentioned this pull request Oct 24, 2022
pixelcmtd added a commit to pixelcmtd/tldr-node-client that referenced this pull request Oct 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants