Skip to content

Conversation

reinhart1010
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

This is a continuation of #8306 with fixes to mistakes spotted by @marchersimon

@github-actions github-actions bot added the translation Issues requesting translating pages from English to other languages. label Oct 3, 2022
@tldr-bot

This comment was marked as outdated.

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, Thanks for your contribution.

Should we update the original pages highlighting the -o option for older clients?

@reinhart1010
Copy link
Collaborator Author

Should we update the original pages highlighting the -o option for older clients?

Our original Node.js client uses --os instead of --platform, and the issue hasn't been fixed for years. See tldr-pages/tldr-node-client#336 for details.

@kbdharun
Copy link
Member

kbdharun commented Oct 3, 2022

Should we update the original pages highlighting the -o option for older clients?

Our original Node.js client uses --os instead of --platform, and the issue hasn't been fixed for years. See tldr-pages/tldr-node-client#336 for details.

Yeah, I noticed the issue before, My question was should we update the English pages too for these commands.

@reinhart1010
Copy link
Collaborator Author

Oh I thought I've done that on #8177 before

@reinhart1010
Copy link
Collaborator Author

Edit: It's under #8297 which is still an open PR

@navarroaxel navarroaxel changed the title invoke-webrequest, iwr, windows/curl, windows/wget: add Indonesian translation invoke-webrequest, iwr, curl, wget: add Indonesian translation Oct 11, 2022
@navarroaxel navarroaxel merged commit 2c311ea into tldr-pages:main Oct 11, 2022
@reinhart1010 reinhart1010 deleted the iwr-indonesian branch December 21, 2022 03:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants