Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix SVG fill attribute bug #12

Closed
wants to merge 1 commit into from
Closed

Fix SVG fill attribute bug #12

wants to merge 1 commit into from

Conversation

mrestko
Copy link

@mrestko mrestko commented Mar 26, 2015

Image Occlusion has been writing SVG tags incorrectly. The "question" shape is supposed to be colored red but instead of setting the fill attribute, this color was being written into a separate style attribute. This is rendered appropriately with desktop Anki, but the Android 5.1 release no longer displays the tag correctly and the result of this is shown in the attached screenshots. This update fixes the fill attribute tag so any Image Occlusion cards created will be displayed correctly on Android.
desktop
ankidroid

@Royal2000H
Copy link

Came across this issue as well. Thanks for the pull request, hopefully it gets merged.
I'm assuming already created cards would probably have an issue still... I wonder if there would be a way to mass fix all cards in a deck.

@mrestko
Copy link
Author

mrestko commented May 3, 2015

Hi Roy-

It seems that development is happening on Bitbucket now. The maintainer accepted the patch when I submitted it there but I don't know if the update has been pushed to Ankiweb yet.

I do have a small python script that I used to fix my own cards. I wasn't really sure how to go about turning it into something that I could submit to the main ImageOcclusion repo. I'll try to clean it up in the next few days and share it myself on my GitHub page.

-Matt Restko

@apb156
Copy link

apb156 commented May 10, 2015

Matt, have you had any luck with turning your python script into something you could share? I need to fix a lot of cards and don't know how to go about it. Could you share your script as is? Thanks.

  • Alex

@mrestko
Copy link
Author

mrestko commented May 11, 2015

Hi all,

I uploaded my card fixing utility. It's pretty rough and I'd like to make it a bit more user friendly. But at least it's up now so you can get your card collections working again.

  • Matt

@apb156
Copy link

apb156 commented May 15, 2015

Thanks a ton Matt. I got the script to run and it seemed to process through all the media. However, after synching everything to AnkiDroid (running LolliPop), only some of the cards are fixed. It looks like mostly cards I got from friends aren't working now. Are there any fine details that I might have overlooked?

@mrestko
Copy link
Author

mrestko commented May 15, 2015

Hi Alex,
Maybe you can open a bug discussion on my repo so that we're having this conversation in the right place. Since I only looked at my own cards when making the script, it's likely that there is a different problem with the cards you got from your friend. If you file a bug report and post some of the broken files, I can take a look and see if I can get it working for you.
-Matt

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants