Replaced the @ sign with the : sign for the primary key value referen… #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce in the BuildPrimaryKeySql method. It was using the @ identifier to assign the value for which primary key to reference. This caused the UpdateAsync(poco) method to not work for Oracle applications because the OracleCommand.Parameters Property requires a : sign, according to the official msdn documentation (https://msdn.microsoft.com/en-us/library/system.data.oracleclient.oraclecommand.parameters.aspx).
|
I hope all is well, @tmenier. Is it possible for you to check the impact on the code for your DBRM of choice that this PR would have? It appears to be crucial for Oracle statements as explained. I have to use a utility method within my projects to construct the Sql from scratch from the pogos to include ':' instead of '@' for the primary key value reference, it's not very feasible in the long run. |
|
I can't accept this because it causes all database tests to fail on all non-Oracle platforms. It's an Oracle-specific bug that needs an Oracle-specific solution. I'll look into it. |
tmenier
added a commit
that referenced
this pull request
Mar 11, 2018
|
@jonast92 @lajjts A fix for this is now available: https://www.nuget.org/packages/AsyncPoco/1.2.1 Please let me know if this resolves the issue for you. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce in the BuildPrimaryKeySql method. It was using the @ identifier to assign the value for which primary key to reference. This caused the UpdateAsync(poco) method to not work for Oracle applications because the OracleCommand.Parameters Property requires a : sign, according to the official msdn documentation (https://msdn.microsoft.com/en-us/library/system.data.oracleclient.oraclecommand.parameters.aspx).