Skip to content

Commit

Permalink
refactor: resolve PD011
Browse files Browse the repository at this point in the history
  • Loading branch information
tmlmt committed Jun 7, 2024
1 parent dbfef3f commit faa79b1
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions milk_tracker/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,9 +341,7 @@ def generate_graph(field: str, title: str, yaxis_title: str) -> dict:
latest_dates = mt.meals.df["date"].drop_duplicates().nlargest(3)

graph_data = []
for _, date in enumerate(
latest_dates
): # TODO @tmlmt: check whether I can loop directly instead of enumerate
for date in latest_dates:
date_data = mt.meals.df[mt.meals.df["date"] == date]
date_data = date_data[
(date_data[field] != "")
Expand All @@ -358,9 +356,9 @@ def generate_graph(field: str, title: str, yaxis_title: str) -> dict:
"mode": "markers+lines",
"x": [
"2024-05-08 " + t
for t in date_data["start_time"].astype(str).values.tolist()
for t in date_data["start_time"].astype(str).array.tolist()
],
"y": date_data[field].values.tolist(),
"y": date_data[field].array.tolist(),
}
)

Expand Down

0 comments on commit faa79b1

Please # to comment.