-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix so that Ignored properties are not included in parameters #267
base: master
Are you sure you want to change the base?
Fix so that Ignored properties are not included in parameters #267
Conversation
… is mapped so that it will properly ignore properties that are mapped using Map().Ignore(),
…fail (without the fix from the previous commit)
I saw your changes and they are working but to approve your PR you need to add tests for all the supported databases not only SQL Server. The tests are using databases on docker and the docker compose file is in the project to help getting them up. Please include tests for the other databases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include tests for the other databases.
Will do. Before I commit, here's a rundown of how the unit tests worked. I've started the different databases in Docker. StartDatabase.ps1 fails with "no such user" from wsl when I try to run it, so I had to use "docker compose up". StartDatabase.ps1 might not be ready yet, from the looks of it. The setup scripts for SQL Server don't work out of the box if the "dapper" database doesn't already exist and Setup.sql needs to run. "USE dapper" fails because SQL Server executes every statement in the batch simultaneously, so CREATE DATABASE hasn't finished yet. Just so you know. Otherwise SQL Server tests run fine. Oracle tests also run fine. So do Sqlite tests. DB2 hangs indefinitely on connect. I don't have any other DB2 clients to test with, so I can't tell yet why it hangs. MySQL/MariaDB fails with the below message and stack trace. Is this normal? Message: Stack Trace: |
See #266 for details