Skip to content

Replacement for distutils.version.LooseVersion, fix warning #351

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Dec 10, 2022

Conversation

tony
Copy link
Member

@tony tony commented Jan 15, 2022

distutils is deprecation Version

The new version will no longer select tmux versions like 3.1 vs 3.1a vs 3.1b.

We will backport LegacyVersion in a typesafe way to tmuxp.

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #351 (68443d6) into master (afb218e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   87.68%   87.80%   +0.11%     
==========================================
  Files          20       21       +1     
  Lines        1852     1869      +17     
  Branches      298      301       +3     
==========================================
+ Hits         1624     1641      +17     
  Misses        154      154              
  Partials       74       74              
Impacted Files Coverage Δ
src/libtmux/common.py 84.03% <100.00%> (-0.08%) ⬇️
tests/test_common.py 97.43% <100.00%> (ø)
tests/test_version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the tn-custom-version branch from 0981555 to 3242c2c Compare December 10, 2022 20:22
@tony tony changed the title Custom, flexible Version implementation Replacement for distutils.version.LooseVersion, fix warning Dec 10, 2022
@tony tony force-pushed the tn-custom-version branch 3 times, most recently from 23e6cfe to e3a44a0 Compare December 10, 2022 20:40
@tony tony force-pushed the tn-custom-version branch from 1fb798c to 68443d6 Compare December 10, 2022 20:43
@tony tony merged commit e3e6c39 into master Dec 10, 2022
@tony tony deleted the tn-custom-version branch December 10, 2022 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant