Skip to content

ruff: Enable pydocstyle w/ numpy convention #509

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 41 commits into from
Nov 25, 2023
Merged

ruff: Enable pydocstyle w/ numpy convention #509

merged 41 commits into from
Nov 25, 2023

Conversation

tony
Copy link
Member

@tony tony commented Nov 25, 2023

@tony tony force-pushed the pydocstyle branch 4 times, most recently from 164490d to ef0707c Compare November 25, 2023 19:09
tony added 3 commits November 25, 2023 13:17
`ruff --show-fixes --fix-only .`

Fixed 72 errors:
- src/libtmux/_internal/dataclasses.py:
     2 × D412 (blank-lines-between-header-and-content)
- src/libtmux/_vendor/version.py:
     1 × D202 (no-blank-line-after-function)
- src/libtmux/common.py:
     3 × D412 (blank-lines-between-header-and-content)
     2 × D211 (blank-line-before-class)
- src/libtmux/exc.py:
    16 × D211 (blank-line-before-class)
- src/libtmux/pane.py:
     2 × D412 (blank-lines-between-header-and-content)
     1 × D202 (no-blank-line-after-function)
- src/libtmux/server.py:
     1 × D202 (no-blank-line-after-function)
- src/libtmux/session.py:
     5 × D202 (no-blank-line-after-function)
- src/libtmux/test.py:
     1 × D202 (no-blank-line-after-function)
- src/libtmux/window.py:
     3 × D202 (no-blank-line-after-function)
     2 × D412 (blank-lines-between-header-and-content)
- tests/legacy_api/test_pane.py:
     1 × D202 (no-blank-line-after-function)
- tests/legacy_api/test_server.py:
     1 × D209 (new-line-after-last-paragraph)
- tests/legacy_api/test_session.py:
     5 × D202 (no-blank-line-after-function)
- tests/legacy_api/test_tmuxobject.py:
     4 × D202 (no-blank-line-after-function)
- tests/legacy_api/test_window.py:
     4 × D202 (no-blank-line-after-function)
     1 × D403 (first-line-capitalized)
- tests/test_pane.py:
     1 × D202 (no-blank-line-after-function)
- tests/test_server.py:
     2 × D209 (new-line-after-last-paragraph)
- tests/test_session.py:
     5 × D202 (no-blank-line-after-function)
- tests/test_tmuxobject.py:
     4 × D202 (no-blank-line-after-function)
- tests/test_window.py:
     4 × D202 (no-blank-line-after-function)
     1 × D403 (first-line-capitalized)

Fixed 72 errors (77 additional fixes available with `--unsafe-fixes`).
`ruff --show-fixes --fix-only --unsafe-fixes .`

Fixed 77 errors:
- conftest.py:
     1 × D400 (ends-in-period)
- docs/conf.py:
     1 × D400 (ends-in-period)
- src/libtmux/_internal/query_list.py:
     2 × D400 (ends-in-period)
- src/libtmux/_vendor/version.py:
     1 × D200 (fits-on-one-line)
- src/libtmux/exc.py:
     8 × D400 (ends-in-period)
- src/libtmux/pane.py:
     6 × D400 (ends-in-period)
     2 × D200 (fits-on-one-line)
- src/libtmux/pytest_plugin.py:
     3 × D400 (ends-in-period)
- src/libtmux/server.py:
     5 × D400 (ends-in-period)
     4 × D200 (fits-on-one-line)
- src/libtmux/session.py:
    10 × D400 (ends-in-period)
     7 × D200 (fits-on-one-line)
- src/libtmux/window.py:
    12 × D400 (ends-in-period)
     6 × D200 (fits-on-one-line)
- tests/legacy_api/test_server.py:
     3 × D400 (ends-in-period)
- tests/legacy_api/test_window.py:
     1 × D400 (ends-in-period)
- tests/test_server.py:
     4 × D400 (ends-in-period)
- tests/test_window.py:
     1 × D400 (ends-in-period)

Fixed 77 errors.
@tony tony force-pushed the pydocstyle branch 2 times, most recently from 7acf007 to 90dafdf Compare November 25, 2023 19:45
Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac19b4b) 88.65% compared to head (368b542) 88.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   88.65%   88.66%           
=======================================
  Files          35       35           
  Lines        3518     3521    +3     
  Branches      488      488           
=======================================
+ Hits         3119     3122    +3     
  Misses        288      288           
  Partials      111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the pydocstyle branch 3 times, most recently from 29d5e28 to 8b89fbd Compare November 25, 2023 21:18
@tony tony force-pushed the pydocstyle branch 3 times, most recently from e90e800 to c9bd68e Compare November 25, 2023 21:21
@tony tony merged commit 3b01dc8 into master Nov 25, 2023
@tony tony deleted the pydocstyle branch November 25, 2023 21:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant