fix: server.attached_sessions #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
A very good catch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 88.75% 88.75%
=======================================
Files 37 37
Lines 3965 3965
Branches 574 575 +1
=======================================
Hits 3519 3519
Misses 304 304
Partials 142 142 ☔ View full report in Codecov by Sentry. |
tony
added a commit
that referenced
this pull request
Mar 23, 2024
|
@patrislav1 If you try 0.35.1 (changes, release, PyPI), any better? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
server.attached_sessionsexcludes sessions that have more than one client attached.