Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support tmux -f option #665

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Support tmux -f option #665

merged 1 commit into from
Feb 3, 2021

Conversation

jfindlay
Copy link
Contributor

Fixes #654. libtmux.server.Server already supports a config option, so extend the option to the tmuxp load command line.

@jfindlay
Copy link
Contributor Author

Not sure if this change warrants a separate unit test, but I can add one if needed.

Fixes tmux-python#654.  `libtmux.server.Server` already supports a `config` option,
so extend the option to the `tmuxp load` command line.
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #665 (a91404d) into master (7bb97ec) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   75.93%   75.95%   +0.02%     
==========================================
  Files           8        8              
  Lines        1180     1181       +1     
  Branches      295      295              
==========================================
+ Hits          896      897       +1     
  Misses        204      204              
  Partials       80       80              
Impacted Files Coverage Δ
tmuxp/cli.py 73.78% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb97ec...a91404d. Read the comment docs.

@tony
Copy link
Member

tony commented Feb 3, 2021

This works, the behavior is exactly like tmux proper. The configs bind to the server

If users want to launch a different tmux server with a totally separate and independent configuration, pass e socket-name (-L) or socket-path (-S)

e.g. tmuxp load yourconfig -f /dev/null -L test will launch a blank tmux server at that socket name

@tony tony merged commit ee8c6e2 into tmux-python:master Feb 3, 2021
@tony
Copy link
Member

tony commented Feb 3, 2021

@jfindlay Thank you! I will follow up with the versions this rolls out for

tony pushed a commit that referenced this pull request Feb 3, 2021
Fixes #654.  `libtmux.server.Server` already supports a `config` option,
so extend the option to the `tmuxp load` command line.
tony pushed a commit that referenced this pull request Feb 3, 2021
Fixes #654.  `libtmux.server.Server` already supports a `config` option,
so extend the option to the `tmuxp load` command line.
@tony
Copy link
Member

tony commented Feb 3, 2021

@jfindlay followed up here: #654 (reply in thread)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants