-
Notifications
You must be signed in to change notification settings - Fork 232
ci(tests) Verify runtime deps #965
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Reviewer's Guide by SourceryThis pull request adds a new job to the CI workflow that verifies the runtime dependencies of the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tony - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the runtime dependency test to a separate job to avoid impacting the main test execution time.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
uv run --no-dev -p python3.13 -- python -c ' from tmuxp import _internal, cli, workspace, exc, log, plugin, shell, types, util, __version__ from tmuxp._internal import config_reader, types from tmuxp.workspace import builder, constants, finders, freezer, importers, loader, validation from libtmux import __version__ as __libtmux_version__ print("tmuxp version:", __version__) print("libtmux version:", __libtmux_version__) ' shell: /usr/bin/bash -e {0} env: UV_CACHE_DIR: /home/runner/work/_temp/setup-uv-cache Using CPython 3.13.2 Creating virtual environment at: .venv Building tmuxp @ file:///home/runner/work/tmuxp/tmuxp Built tmuxp @ file:///home/runner/work/tmuxp/tmuxp Installed 4 packages in 1ms Traceback (most recent call last): File "<string>", line 3, in <module> from tmuxp._internal import config_reader, types File "/home/runner/work/tmuxp/tmuxp/src/tmuxp/_internal/types.py", line 15, in <module> from typing_extensions import NotRequired, TypedDict ModuleNotFoundError: No module named 'typing_extensions'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
+ Coverage 73.06% 73.07% +0.01%
==========================================
Files 26 26
Lines 1856 1857 +1
Branches 352 352
==========================================
+ Hits 1356 1357 +1
Misses 396 396
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Follow up to #965, cover import imports to test runtime behavior to make sure we're not importing dev deps.
Changes
uv run --no-dev
Verification
https://github.com/tmux-python/tmuxp/actions/runs/13411308953/job/37461974473#step:5:24
See also
Summary by Sourcery
CI: