Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix "use strict" errors #294

Closed
wants to merge 6 commits into from
Closed

Fix "use strict" errors #294

wants to merge 6 commits into from

Conversation

chtheis
Copy link

@chtheis chtheis commented Aug 8, 2020

Some fixes where undeclared variables are used which is not allowed under "use strict"

@codecov-commenter
Copy link

Codecov Report

Merging #294 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #294   +/-   ##
=========================================
  Coverage     96.16%   96.16%           
  Complexity      920      920           
=========================================
  Files            56       56           
  Lines          2320     2320           
  Branches        369      369           
=========================================
  Hits           2231     2231           
  Misses           48       48           
  Partials         41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb716c...11ffbcb. Read the comment docs.

@tntim96
Copy link
Owner

tntim96 commented Oct 27, 2022

Hi @chtheis , sorry for not following up on this sooner. I believe this has been fixed in #311 , commit 0eca598. Can you confirm?

@tntim96
Copy link
Owner

tntim96 commented Nov 2, 2022

This is a fix for #293

@tntim96
Copy link
Owner

tntim96 commented Nov 2, 2022

Fixed in #311 , commit 0eca598

@tntim96 tntim96 closed this Nov 2, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants