Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed typoes in readme and fixed error in MHZ.cpp files #24

Merged
merged 3 commits into from
Sep 28, 2021
Merged

fixed typoes in readme and fixed error in MHZ.cpp files #24

merged 3 commits into from
Sep 28, 2021

Conversation

CollieIsCute
Copy link
Contributor

I noticed that a type name of sensor in readme, "MH-Z18B", isn't found in the header. I've also googled "MH-Z18B", but I didn't find anything relative.

I guess you mean the "MH-Z19B" CO2 sensor, so I correct it. If I make any mistake, please let me know, tks.

@CollieIsCute
Copy link
Contributor Author

plz merge the branch to correct the readme, thanks.

Collie Cute added 2 commits August 10, 2021 18:28
In Uno, it's 16 bits in int variable. So I add a explicit type cast in MHZ.cpp file
I change the data type to unit_8t, and it also helps to unify the datatype of these cmd arrays.
@CollieIsCute
Copy link
Contributor Author

  • MHZ14A_RESPONSE_TIME, and MHZ19B_RESPONSE_TIME are 32bits variable. However, the size of int is not constant. It varies in different board. So I found it overflowed in my Uno board. I add a type cast to fix this problem.
  • fix the implicit datatype convert warning.

@CollieIsCute CollieIsCute changed the title correction in readme fixed typoes in readme and fix error in MHZ.cpp files Aug 10, 2021
@CollieIsCute CollieIsCute changed the title fixed typoes in readme and fix error in MHZ.cpp files fixed typoes in readme and fixed error in MHZ.cpp files Aug 10, 2021
@tobiasschuerg tobiasschuerg merged commit 7be7cf0 into tobiasschuerg:master Sep 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants