Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: modify empty text & style of favorite & pinboard #1977

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Conversation

QiShaoXuan
Copy link
Contributor

No description provided.

@QiShaoXuan QiShaoXuan requested a review from JimmFly as a code owner April 17, 2023 03:44
@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 17, 2023 4:35am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 4:35am

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cae955b
Status: ✅  Deploy successful!
Preview URL: https://c548efc6.affine.pages.dev
Branch Preview URL: https://fix-ui.affine.pages.dev

View logs

@github-actions github-actions bot added app:web mod:i18n Related to i18n labels Apr 17, 2023
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 03:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 03:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 03:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 03:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 03:48 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 17, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master         fix/ui                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB      +413 B(+0.01%)   
< Initial JS          1.89 MB        1.89 MB      +413 B(+0.02%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master         fix/ui                 +/- ##
===================================================================
< Bundle              4.17 MB        4.17 MB      +413 B(+0.01%)   
< Initial JS          1.79 MB        1.79 MB      +413 B(+0.02%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master         fix/ui                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 03:59 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 04:01 Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:29 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 04:30 Inactive
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: -0.04 ⚠️

Comparison is base (f534e4a) 75.45% compared to head (cae955b) 75.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1977      +/-   ##
==========================================
- Coverage   75.45%   75.41%   -0.04%     
==========================================
  Files         278      278              
  Lines        5378     5382       +4     
  Branches     1045     1043       -2     
==========================================
+ Hits         4058     4059       +1     
- Misses       1086     1087       +1     
- Partials      234      236       +2     
Flag Coverage Δ
e2etest 74.59% <66.66%> (-0.03%) ⬇️
storybook-test 50.63% <ø> (ø)
unittest 45.73% <31.25%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/affine/pinboard/pinboard-render/EmptyItem.tsx 100.00% <ø> (ø)
...ponents/pure/workspace-slider-bar/shared-styles.ts 51.61% <0.00%> (-1.73%) ⬇️
apps/web/src/components/affine/pinboard/styles.ts 63.33% <33.33%> (+0.37%) ⬆️
.../pure/workspace-slider-bar/favorite/empty-item.tsx 100.00% <100.00%> (ø)
...re/workspace-slider-bar/favorite/favorite-list.tsx 75.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 17, 2023 04:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:31 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 17, 2023 04:31 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 04:35 Inactive
@QiShaoXuan QiShaoXuan merged commit 19894aa into master Apr 17, 2023
@QiShaoXuan QiShaoXuan deleted the fix/ui branch April 17, 2023 05:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:web mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants