Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add shared page empty tip #2077

Merged
merged 4 commits into from
Apr 22, 2023
Merged

feat: add shared page empty tip #2077

merged 4 commits into from
Apr 22, 2023

Conversation

tzhangchi
Copy link
Contributor

No description provided.

@tzhangchi tzhangchi requested a review from JimmFly as a code owner April 22, 2023 01:52
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 22, 2023 10:18pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2023 10:18pm

@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:52 — with GitHub Actions Inactive
@github-actions github-actions bot added app:web mod:i18n Related to i18n labels Apr 22, 2023
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:55 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:56 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:56 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:56 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 01:56 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.30 ⚠️

Comparison is base (2c95a0a) 74.15% compared to head (aee980a) 73.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
- Coverage   74.15%   73.86%   -0.30%     
==========================================
  Files         299      298       -1     
  Lines        5931     5972      +41     
  Branches     1093     1096       +3     
==========================================
+ Hits         4398     4411      +13     
- Misses       1311     1335      +24     
- Partials      222      226       +4     
Flag Coverage Δ
e2etest 72.58% <77.77%> (-0.28%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.05% <ø> (ø)
unittest 37.27% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ocksuite/block-suite-page-list/page-list/Empty.tsx 84.61% <0.00%> (-15.39%) ⬇️
...src/components/pure/workspace-slider-bar/index.tsx 88.63% <ø> (ø)
...web/src/components/affine/sidebar-switch/index.tsx 96.15% <100.00%> (+1.41%) ⬆️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aee980a
Status: ✅  Deploy successful!
Preview URL: https://ef17ee93.affine.pages.dev
Branch Preview URL: https://feat-sharedpage-tip.affine.pages.dev

View logs

@perfsee
Copy link

perfsee bot commented Apr 22, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …haredpage-tip                 +/- ##
===================================================================
> Bundle              4.26 MB        4.26 MB      -535 B(-0.01%)   
> Initial JS          1.75 MB        1.74 MB      -683 B(-0.04%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …haredpage-tip                 +/- ##
===================================================================
> Bundle              4.16 MB        4.15 MB      -535 B(-0.01%)   
> Initial JS          1.64 MB        1.64 MB      -683 B(-0.04%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …haredpage-tip                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 22, 2023 02:19 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 22, 2023 02:23 Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:42 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:45 — with GitHub Actions Inactive
@tzhangchi tzhangchi changed the title feat:add shared page empty tip #2076 feat: add shared page empty tip #2076 Apr 22, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 22, 2023 12:46 Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:46 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:46 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:46 — with GitHub Actions Inactive
@tzhangchi tzhangchi temporarily deployed to development April 22, 2023 12:46 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 22, 2023 12:50 Inactive
@himself65 himself65 changed the title feat: add shared page empty tip #2076 feat: add shared page empty tip Apr 22, 2023
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:05 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 22, 2023 22:13 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 22, 2023 22:18 Inactive
@himself65 himself65 merged commit 70d8f9a into master Apr 22, 2023
@himself65 himself65 deleted the feat/sharedpage-tip branch April 22, 2023 22:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:web mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants