build: fix electron build gain focus on reloading in dev #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2088 +/- ##
==========================================
- Coverage 73.91% 73.90% -0.02%
==========================================
Files 298 298
Lines 5980 5981 +1
Branches 1105 1097 -8
==========================================
Hits 4420 4420
- Misses 1334 1335 +1
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
ad9e520
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://323cfa3a.affine.pages.dev |
| Branch Preview URL: | https://0423-fix-electron-dev.affine.pages.dev |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master …/electron-dev +/- ##
===================================================================
< Bundle 4.26 MB 4.26 MB +71 B(+0.00%)
< Initial JS 1.75 MB 1.75 MB +71 B(+0.00%)
= Initial CSS 13.2 kB 13.2 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 43 43
= Chunks 41 41
= Packages 150 150
= Duplicates 5 5
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master …/electron-dev +/- ##
===================================================================
< Bundle 4.16 MB 4.16 MB +71 B(+0.00%)
< Initial JS 1.64 MB 1.64 MB +71 B(+0.00%)
= Initial CSS 13.2 kB 13.2 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 41 41
= Chunks 39 39
= Packages 150 150
= Duplicates 5 5
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master …/electron-dev +/- ##
===================================================================
= Bundle 16.7 kB 16.7 kB
= Initial JS 16.7 kB 16.7 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
himself65
approved these changes
Apr 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at ad9e520
This pull request enhances the electron app's logging, window showing, and protocol handling. It adds more log messages to
main-window.tsanddev.mjs, and adjusts the window showing logic based on thedevelopmentmode. It also removes the node environment check for the file and assets protocols inprotocol.ts, and deletes an obsolete TODO comment inpreload.ts.showInactiveinstead ofshowwhen creating new window in development