Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: some improvements to electron app #2089

Merged
merged 8 commits into from
Apr 24, 2023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 23, 2023

@vercel
Copy link

vercel bot commented Apr 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 24, 2023 3:59pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 3:59pm

@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:03 — with GitHub Actions Inactive
@github-actions github-actions bot added app:electron Related to electron app mod:workspace Related to workspace labels Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 67.79% and project coverage change: +1.14 🎉

Comparison is base (ab86698) 72.68% compared to head (e2ceeae) 73.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
+ Coverage   72.68%   73.82%   +1.14%     
==========================================
  Files         289      308      +19     
  Lines        5517     6205     +688     
  Branches      873     1118     +245     
==========================================
+ Hits         4010     4581     +571     
- Misses       1267     1395     +128     
+ Partials      240      229      -11     
Flag Coverage Δ
e2etest 72.42% <0.00%> (-0.22%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 48.77% <ø> (-0.29%) ⬇️
unittest 39.42% <67.79%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/electron/layers/main/src/send-main-event.ts 0.00% <0.00%> (ø)
apps/electron/layers/main/src/handlers.ts 62.83% <54.54%> (ø)
packages/workspace/src/providers/index.ts 65.65% <73.91%> (+29.18%) ⬆️
apps/electron/layers/main/src/data/sqlite.ts 85.50% <90.00%> (ø)
apps/electron/layers/main/src/data/fs-watch.ts 100.00% <100.00%> (ø)

... and 115 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:05 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 23, 2023 10:07 Inactive
@perfsee
Copy link

perfsee bot commented Apr 23, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …b-file-change                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB      +308 B(+0.01%)   
< Initial JS          1.75 MB        1.75 MB      +308 B(+0.02%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …b-file-change                 +/- ##
===================================================================
< Bundle              4.16 MB        4.16 MB      +308 B(+0.01%)   
< Initial JS          1.65 MB        1.65 MB      +308 B(+0.02%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …b-file-change                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:08 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:08 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:08 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 23, 2023 10:08 — with GitHub Actions Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2ceeae
Status: ✅  Deploy successful!
Preview URL: https://3d40de8f.affine.pages.dev
Branch Preview URL: https://0423-feat-watch-db-file-chan.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 23, 2023 10:11 Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 08:30 — with GitHub Actions Inactive
@github-actions github-actions bot added the docs Improvements or additions to documentation label Apr 24, 2023
@pengx17 pengx17 temporarily deployed to development April 24, 2023 15:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 15:54 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 15:54 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 24, 2023 15:55 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 24, 2023 15:59 Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 16:52 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@pengx17 pengx17 temporarily deployed to development April 24, 2023 17:24 — with GitHub Actions Inactive
@himself65 himself65 merged commit c27c241 into master Apr 24, 2023
@himself65 himself65 deleted the 0423/feat/watch-db-file-change branch April 24, 2023 17:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
app:electron Related to electron app docs Improvements or additions to documentation mod:workspace Related to workspace
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants