fix: closing modal sometimes covered by header

[pengx17]

fix #2094

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
affine-preview	✅ Ready (Inspect)	Visit Preview		Apr 23, 2023 2:41pm
affine-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 23, 2023 2:41pm

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (be9095e) 73.84% compared to head (8f8d015) 73.89%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   73.84%   73.89%   +0.05%     
==========================================
  Files         298      298              
  Lines        5980     5980              
  Branches     1102     1105       +3     
==========================================
+ Hits         4416     4419       +3     
+ Misses       1337     1334       -3     
  Partials      227      227              

Flag	Coverage Δ
e2etest	72.64% <ø> (+0.08%)	⬆️
server-test	90.78% <ø> (ø)
storybook-test	49.05% <ø> (ø)
unittest	37.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/component/src/ui/modal/styles.ts	77.77% <ø> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[perfsee]

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …x/electron-ui                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB       +97 B(+0.00%)   
< Initial JS          1.75 MB        1.75 MB       +97 B(+0.01%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …x/electron-ui                 +/- ##
===================================================================
< Bundle              4.16 MB        4.16 MB       +97 B(+0.00%)   
< Initial JS          1.65 MB        1.65 MB       +97 B(+0.01%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …x/electron-ui                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	8f8d015
Status:	✅  Deploy successful!
Preview URL:	https://8fd4214a.affine.pages.dev
Branch Preview URL:	https://0423-fix-electron-ui.affine.pages.dev

View logs