Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: text overflow problem in <a> tag #2126

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: text overflow problem in <a> tag #2126

merged 1 commit into from
Apr 25, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 25, 2023

Close #2096

2023-04-25.19.14.09.mov

@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 25, 2023 11:21am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 11:21am

@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 25, 2023 11:16 Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:16 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.32 ⚠️

Comparison is base (a807647) 74.03% compared to head (18a70ac) 72.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2126      +/-   ##
==========================================
- Coverage   74.03%   72.72%   -1.32%     
==========================================
  Files         302      302              
  Lines        6005     6005              
  Branches     1074     1074              
==========================================
- Hits         4446     4367      -79     
- Misses       1349     1422      +73     
- Partials      210      216       +6     
Flag Coverage Δ
e2etest 70.41% <ø> (-2.00%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.43% <ø> (ø)
unittest 35.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/pure/workspace-slider-bar/index.tsx 85.00% <ø> (-2.50%) ⬇️
...ponents/pure/workspace-slider-bar/shared-styles.ts 100.00% <ø> (ø)
.../src/components/pure/workspace-slider-bar/style.ts 94.44% <ø> (ø)

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 18a70ac
Status: ✅  Deploy successful!
Preview URL: https://63caf68b.affine.pages.dev
Branch Preview URL: https://fix-silder-bar.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-preview April 25, 2023 11:21 Inactive
@perfsee
Copy link

perfsee bot commented Apr 25, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master fix/silder-bar                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB    +10.5 kB(+0.25%)   
> Initial JS          1.75 MB        1.75 MB      -424 B(-0.02%)   
< Initial CSS         13.2 kB        14.6 kB   +1.48 kB(+11.24%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master fix/silder-bar                 +/- ##
===================================================================
< Bundle              4.16 MB        4.17 MB    +10.5 kB(+0.25%)   
> Initial JS          1.65 MB        1.65 MB      -424 B(-0.03%)   
< Initial CSS         13.2 kB        14.6 kB   +1.48 kB(+11.24%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master fix/silder-bar                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 11:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 16:36 — with GitHub Actions Inactive
@himself65 himself65 merged commit 15a7e93 into master Apr 25, 2023
@himself65 himself65 deleted the fix/silder-bar branch April 25, 2023 16:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

​Outgoing text in demo
2 participants